Add pg_upgrade test to CI #6951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziomello
force-pushed
the
ci_add_pg_upgrade_test_workflow
branch
2 times, most recently
from
9ed50ae to
842fd69
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6951 +/- ##
==========================================
+ Coverage 80.06% 81.68% +1.61%
==========================================
Files 190 198 +8
Lines 37181 36849 -332
Branches 9450 9631 +181
==========================================
+ Hits 29770 30099 +329
+ Misses 2997 2872 -125
+ Partials 4414 3878 -536 ☔ View full report in Codecov by Sentry. |
fabriziomello
force-pushed
the
ci_add_pg_upgrade_test_workflow
branch
15 times, most recently
from
f6c4f9b to
b49315c
Compare
fabriziomello
added
ci
pg-upgrade
fabriziomello
force-pushed
the
ci_add_pg_upgrade_test_workflow
branch
2 times, most recently
from
274abfe to
eee6bd3
Compare
fabriziomello
force-pushed
the
ci_add_pg_upgrade_test_workflow
branch
2 times, most recently
from
00a649a to
2288d96
Compare
svenklemm
reviewed
May 24, 2024
svenklemm
approved these changes
May 24, 2024
Member
|
LGTM |
fabriziomello
force-pushed
the
ci_add_pg_upgrade_test_workflow
branch
from
2288d96 to
09a5a50
Compare
fabriziomello
force-pushed
the
ci_add_pg_upgrade_test_workflow
branch
5 times, most recently
from
40ce12e to
8cb9e44
Compare
It's long we need to have binary upgrade tests in our CI. One example is timescale#6935 (and others) that can be prevented if we have such kind of test in our CI. To implement the `pg_upgrade` test we used the python Testing Framework for PostgreSQL (https://github.com/postgrespro/testgres). Unfortunately the testing framework don't have the ability to retain the pg_upgrade log files after a successful execution, then we created a PR to make it possible and we'll use this patched version until we get the code merged and released on upstream. postgrespro/testgres#125 Closes timescale#3868 timescale#4428
fabriziomello
force-pushed
the
ci_add_pg_upgrade_test_workflow
branch
from
8cb9e44 to
3adbab2
Compare
antekresic
approved these changes
May 26, 2024
Member
antekresic
left a comment
antekresic
left a comment
There was a problem hiding this comment.
Minor question, otherwise lgmt
| pip list | ||
| pip list --user | ||
| # Using e375302a until 1.10.1 get released including the following PR |
Member
There was a problem hiding this comment.
Whats the reason for putting this into code style workflow?
Member
Author
There was a problem hiding this comment.
Because pylint complains due to the change I've made on upstream (postgrespro/testgres@e375302). Once it get released we can just use the pip package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's long we need to have binary upgrade tests in our CI. One example is #6935 (and others) that can be prevented if we have such kind of test in our CI.
To implement the
pg_upgradetest we used the python Testing Framework for PostgreSQL (https://github.com/postgrespro/testgres).Unfortunately the testing framework don't have the ability to retain the pg_upgrade log files after a successful execution, then we created a PR to make it possible and we'll use this patched version until we get the code merged and released on upstream.
postgrespro/testgres#125
Closes #3868 #4428
Disable-check: force-changelog-file