Fix #2 (Panic when parsing argument list with an empty string)#3
Open
rollcat wants to merge 1 commit intotimtadh:masterfrom
Open
Fix #2 (Panic when parsing argument list with an empty string)#3rollcat wants to merge 1 commit intotimtadh:masterfrom
rollcat wants to merge 1 commit intotimtadh:masterfrom
Conversation
timtadh
approved these changes
Jul 27, 2023
Owner
timtadh
left a comment
timtadh
left a comment
There was a problem hiding this comment.
LGTM modulo my comment on && versus ||.
| break | ||
| } else if skip { | ||
| if arg[0] == '-' { | ||
| if len(arg) > 0 && arg[0] == '-' { |
Owner
There was a problem hiding this comment.
should this be len(arg) <= 0 || arg[0] == '-'. I think you want || instead so that you still return an error about the missing argument for the emitted option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.