fix: Windows characteristic ordering in DiscoverCharacteristics#410
Merged
deadprogram merged 2 commits intotinygo-org:devfrom Mar 1, 2026
Merged
fix: Windows characteristic ordering in DiscoverCharacteristics#410deadprogram merged 2 commits intotinygo-org:devfrom
deadprogram merged 2 commits intotinygo-org:devfrom
Conversation
acouvreur
force-pushed
the
fix-windows-chars-ordering
branch
from
5b9e362 to
a6372a2
Compare
The characteristics will now appear on the expected order
acouvreur
force-pushed
the
fix-windows-chars-ordering
branch
from
a6372a2 to
3b41425
Compare
Member
|
Seems legit to me. @jagobagascon any comment on this before merge? |
jagobagascon
requested changes
Feb 25, 2026
Member
jagobagascon
left a comment
jagobagascon
left a comment
There was a problem hiding this comment.
I was hoping to get some time slot to test this.
jagobagascon
approved these changes
Feb 26, 2026
Member
|
LGTM! |
Member
|
Thank you for working on this @acouvreur and to @jagobagascon for review/feedback. Now squash/merging. |
This was referenced Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The characteristics will now appear on the expected order.
Closes #409