Allow Go 1.15 #1276
Closed
Allow Go 1.15 #1276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To clarify, it works on 0.13.1, but I guess new stuff on |
|
Failure looks related to this re-organization: golang/go@18a6fd4 |
|
Same problem exists in the Go 1.15 release. Which now that it has been released, suddenly becomes a big priority. 😸 |
|
This commit gets all the tests to pass: 2abcd01 |
|
@aykevl what do you think? |
|
I have a branch with the various changes needed for 1.15 here: #1293 Everything appears to be working on Linux, I also did manual testing on SAMD21. However, Windows has a problem #1293 (comment) |
|
Thanks for finishing that up. I meant to get back to this on the weekend, but didn't find the time in the end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This all seemed to magically work (
go testand smoketests), but let's see how CI feels about it.