Skip to content

compiler: test float to int conversions and fix upper-bound calculation #1582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2021
Merged

compiler: test float to int conversions and fix upper-bound calculation #1582

merged 1 commit into from
Jan 19, 2021

Conversation

niaow
Copy link
Member

@niaow niaow commented Jan 16, 2021

This should have gone into #1574

@niaow niaow marked this pull request as ready for review January 16, 2021 20:05
@niaow
Copy link
Member Author

niaow commented Jan 16, 2021

@aykevl I think this should address some of your concerns from #1574, and indeed the additional testing revealed a single broken edge case (the expression for the upper bound was missing parentheses, resulting in UB).

@niaow niaow requested a review from aykevl January 16, 2021 21:21
aykevl
aykevl approved these changes Jan 19, 2021
View reviewed changes
Copy link
Member

@aykevl aykevl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the added testing and the fix, this looks good.

@aykevl aykevl merged commit a5cf704 into tinygo-org:dev Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aykevl aykevl aykevl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niaow @aykevl