transform: fix bug in interface lowering when signatures are renamed #1768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In rare cases the signature might change as a result of LLVM renaming some named struct types when multiple LLVM modules are merged. The easiest workaround is to detect such mismatched signatures and adding a bitcast: this should be safe as the underlying data is effectively of the same type.
|
Confirmed that I can now build that program with this PR. Thanks for the quick fix @aykevl now merging. |
dgryski
pushed a commit
to dgryski/tinygo
that referenced
this pull request
Oct 21, 2021
This fix is very similar to tinygo-org#1768, but now for the return type. It fixes the issue in tinygo-org#1887. Like tinygo-org#1768, I'm not sure how to test this as it is very specific to certain renames that LLVM does and that don't seem very reproducable.
ardnew
pushed a commit
to ardnew/tinygo
that referenced
this pull request
Jun 21, 2022
This fix is very similar to tinygo-org#1768, but now for the return type. It fixes the issue in tinygo-org#1887. Like tinygo-org#1768, I'm not sure how to test this as it is very specific to certain renames that LLVM does and that don't seem very reproducable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rare cases the signature might change as a result of LLVM renaming
some named struct types when multiple LLVM modules are merged. The
easiest workaround is to detect such mismatched signatures and adding a
bitcast: this should be safe as the underlying data is effectively of
the same type.
This should fix #1765.
Note that this doesn't have tests as I don't really know the exact behavior of LLVM module merging and I have no idea what a good test would look like. Additionally, I intend to refactor this code in the future in a way that might avoid this issue entirely.