Skip to content

build: double timeout period without output for make test #2159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2021
Merged

build: double timeout period without output for make test #2159

merged 1 commit into from
Oct 4, 2021

Conversation

deadprogram
Copy link
Member

This PR fixes issues with the CircleCI build by doubling the timeout period without output for make test.

aykevl
aykevl approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@aykevl aykevl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. However, I believe Go itself also has a timeout of 10 minutes for tests, so we might hit that one next. For now, 20 minutes should be good enough.

(Off-topic: we might want to investigate ways to lower test duration)

@deadprogram
Copy link
Member Author

(Off-topic: we might want to investigate ways to lower test duration)

please oh please! 👍

Merging.

@deadprogram deadprogram merged commit 98fbf7f into dev Oct 4, 2021
@deadprogram deadprogram deleted the circleci-longer-timeout branch October 4, 2021 21:51
@aykevl aykevl mentioned this pull request Oct 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aykevl aykevl aykevl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deadprogram @aykevl