runtime (js/wasm): avoid scheduler recursion #2178
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wasm "log" test attaches a callback to a button and then triggers a click event. The click event then calls back into the WASM module, spawning another copy of the scheduler loop. This change detects this kind of nesting and will now spawn the event handler but not the scheduler. A debug assertion has also been added to the scheduler to help track down similar issues in the future.
Member
Author
|
Nevermind, I seem to have messed up something between testing and committing. . . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wasm "log" test attaches a callback to a button and then triggers a click event.
The click event then calls back into the WASM module, spawning another copy of the scheduler loop.
This change detects this kind of nesting and will now spawn the event handler but not the scheduler.
A debug assertion has also been added to the scheduler to help track down similar issues in the future.