-
Notifications
You must be signed in to change notification settings - Fork 951
Add LLVM 12 support #2300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LLVM 12 support #2300
Conversation
Aside from coroutine issues, does this fix any issues that were hitting tinygo? |
Not directly, but it's important to stay up to date with LLVM. Some reasons:
|
0777c5d
to
86d9cc9
Compare
Originally based on a PR by @QuLogic, but extended a lot to get all tests to pass.
This is now, finally, ready for review. It took a lot of work (most importantly, #2011) to get LLVM 12 supported but so far all tests seem to be passing. |
Seems like all TinyHCI tests are passing except MAIt BiT which is our only RISC-V 64-bit platform. Have to dig in a little more here. Program compiles and flashes just fine, but no response from serial. |
Hmm, that's kind of difficult for me to debug as I don't have the hardware. I don't see anything obviously wrong with the binary either. One thing you could try is to set the linker to the LLVM 11 linker and see whether that works. You can do this by modifying the maixbit.json file and add
(Or similar, depending on how you've installed LLVM). |
Using a container with this build, I can determine that even blinky1 does not run on the Maixbit with this branch. The container I used for testing did not have LLVM installed, as it uses the build from the CI. I will have to try a different container for this test. |
You can also build locally, using |
I will setup jlink and gdb to try to look into this a bit more. In the meantime, since it is not commonly used apparently, I have disabled that board from TinyHCI in the interest of getting this PR merged sooner. Also have installed locally, so I will try out with some of my various demos and toys. |
Confirmed that a couple of my Bluetooth examples are working as expected with this branch. As far as I am concerned, we should merge it, and then later look into any specific issues on the Maxibit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I tried it out locally and cannot find any issues. Not sure about the maixbit issue.
Originally based on a PR by @QuLogic, but extended a lot to get all tests to pass.
Work in progress. The remaining parts is build-linux, which can't complete its run on CircleCI because of the 1 hour job run limit.