Partially support BenchmarkXXX functions with the -bench and -test.bench flags #2487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkegel-fastly
force-pushed
the
dkegel-yet-moar-benchmark
branch
3 times, most recently
from
a291379 to
c46ba91
Compare
|
Will go green after #2488 lands or the images are updated. ( Although it might take several retries... there seem to be multiple flaky CI failure modes, see e.g. the three failed runs before https://github.com/tinygo-org/tinygo/runs/4722737811 ) |
…o easier On the theory that tinygo is tending towards smaller diffs with go... Also adds placeholder for ReportAllocs(), otherwise zero semantic changes.
dkegel-fastly
force-pushed
the
dkegel-yet-moar-benchmark
branch
from
c46ba91 to
87993ca
Compare
|
I think this is ready. I hope to add support for sub-benchmarks soon, but even without them it seems useful. Let's land it with all three commits intact, I am looking forward to seeing what /proc/cpuinfo says on a bad ci run. |
dkegel-fastly
changed the title
|
OK this should be very interesting. Thanks for working on this, been wanting some benchmarks myself for a while. Now merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had this sitting around half-finished for a long time, just today I needed benchmarks, and suddenly the last little bit got much easier to write :-)