testing: implement Cleanup(), with tests #2505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkegel-fastly
force-pushed
the
dkegel-testing-add-cleanup
branch
from
569b539 to
5700168
Compare
|
Please resolve merge conflict. Thanks. |
No change in behavior, just preparing for next commit, and gently nudging code closer to upstream.
Also reorder and regroup common's fields slightly to match upstream. TODO: pull in more upstream tests once this package is goroutine-safe
dkegel-fastly
force-pushed
the
dkegel-testing-add-cleanup
branch
from
5700168 to
5d5ad88
Compare
|
Thank you @dkegel-fastly now merging. |
aykevl
reviewed
Jan 24, 2022
|
|
||
| // matchStringOnly is part of upstream, and is used below to provide a dummy deps to pass to MainStart | ||
| // so it can be run with go (tested with go 1.16) to provide a baseline for the regression test. | ||
| // See c56cc9b3b57276. Unfortunately, testdeps is internal, so we can't just use &testdeps.TestDeps{}. |
There was a problem hiding this comment.
Unfortunately, testdeps is internal, so we can't just use &testdeps.TestDeps{}.
That's not the reason: the testing package can most certainly import internal packages because they're both part of GOROOT. The reason that testdeps exists is so that the testing package can import useful packages while those packages can still import the testing package (for their own tests) without creating a circular dependency.
There was a problem hiding this comment.
Oops, nevermind. The comment is correct. I didn't realize the code was in testdata/testing.go (instead of src/testing.go).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
t.Cleanup() will be needed when we implement t.TempDir().
Land it now with tests to reduce the size of the future pull request for t.TempDir().
Also update testdata/testing.go to run properly with go 1.16 (it crashed without this).
This was useful while I was debugging the tRunner() change.