os: Seek: provide stub for syscall.seek on i386 and arm. #2571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…go-org#1906" This reverts commit 60b483b.
This replaces an earlier kludge which was at the wrong level and caused "GOARCH=386 tinygo test os" to fail to compile on linux. Stubbing just the one missing function, syscall.seek, lets os tests compile on linux 386, and skipping tests of seek and Fstat (which has a cryptic dependency on syscall.Seek via time) lets os tests pass on linux 386. The stub can be removed once tinygo implements go assembly and picks up the real definition.
This was referenced Jan 22, 2022
|
This is part of #2499 (the pull request that exposed the need for this fix), so you could just merge that and close this one if you like. |
Merged
|
Thanks for the fix @dkegel-fastly let's get it in for 0.22 Now merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets 'GOARCH=386 tinygo test os' compile on linux.
Replaces the patch "Kludge: work around lack of syscall.seek on 386 and arm, #1906", which tried to do the same thing but at a higher level, thus failing to catch the direct reference to syscall.Seek in the time package.
Also skip tests that depend on seek so "GOARCH=386 tinygo test os" passes again on linux.
TODO: add CI runners that test os on 386 and arm?