runtime: implement resetTimer #3094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeshaw
force-pushed
the
joeshaw/implement-resettimer
branch
2 times, most recently
from
651b18d to
6e040c1
Compare
|
Looks like you might need to rebase against the latest |
|
It was latest |
joeshaw
force-pushed
the
joeshaw/implement-resettimer
branch
from
6e040c1 to
6e01da5
Compare
|
Actually, I think it was just flaky test timing. Force-pushed an update to hopefully fix that 🤞 |
deadprogram
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runtime: implement resetTimer
A follow up to #2954 / #1402, which implemented startTimer and stopTimer.