Skip to content

cgo: allow LDFLAGS: --export=... #3702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2023
Merged

Conversation

evacchi
Copy link
Contributor

@evacchi evacchi commented May 4, 2023

As discussed in tetratelabs/wazero#1429, add --export to the accepted LDFLAGS.
Manually tested on greet.go by adding the line:

// #cgo LDFLAGS: --export=malloc --export=free

Signed-off-by: Edoardo Vacchi <[email protected]>
@evacchi evacchi changed the base branch from release to dev May 4, 2023 13:39
@evacchi evacchi changed the title cgo export cgo: allow LDFLAGS: --export=... May 4, 2023
Copy link
Member

@dgryski dgryski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aykevl aykevl merged commit 4e41e90 into tinygo-org:dev May 4, 2023
@evacchi evacchi deleted the cgo-export branch May 4, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants