Closed
Conversation
7da9ea9 to
5531979
Compare
Member
Author
|
Progress! After rebasing to incorporate the changes in #486, the amount of successful checks goes from 1 to 3 (of 4). And I know what goes wrong in the 4th one (test-llvm8-go111). |
Member
Author
|
The main limitation now is that code like the following causes a compiler error: package main
type asdf struct {
next []asdf
}
func main() {
foo(new(asdf))
}
func foo(x *asdf) {
}(The issue here is the struct that contains a slice of itself). |
This was referenced Aug 10, 2019
fd84d53 to
4eec52f
Compare
Previously, all functions were processed first by the ir package which scanned them all for reachability. Only the reachable functions were compiled to LLVM IR. This change removes this dead code elimination pass, and in fact refactors most of that infrastructure. This cleans up the compiler and should open the door for caching the compilation and optimization of packages.
4eec52f to
93f32bc
Compare
Member
Author
|
Replaced by #1008. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large change that:
This is in preparation of fixing #285. Not ready for merging, as it's not complete (some packages that previously compiled break with this change) and I want to review/improve it myself a bit, and add real commit messages.
This change will increase compile times, but should decrease massively once #285 is ready and package builds can be cached.