feat: allow bidirectional usb endpoint numbers #5014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikesmitty
force-pushed
the
ms/allow-endpoint-number-sharing
branch
from
3288f5e to
0f3d0c3
Compare
|
Ok, all ready for review now. I don't have any atsamd21 boards, but I've tested USB CDC on an atsamd51, nrf52840, and a pico-w as well as USB mass storage on the pico-w and everything looks good to me |
aykevl
reviewed
Aug 27, 2025
|
Did a quick test on a Circuit Playground Express (atsamd21) and it seems to be working fine! |
|
@mikesmitty I just switched the branch for this to Anyone else have any comments on this PR? |
|
Sure, I'll squash them all |
mikesmitty
force-pushed
the
ms/allow-endpoint-number-sharing
branch
from
ba24793 to
0066bb3
Compare
|
Before merge, just want to confirm with @sago35 that this does not affect any TinyGo Keeb code. ⌨️ |
|
I’ll make sure to review it early next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is still a bit fresh, will update once it's had a bit more time to cook