[joeshaw]

TinyGo side follow up to tinygo-org/go-llvm#86

llvm.LinkModules creates a new llvm::Linker for every package, and each one collects the struct types of the whole destination module first, so linking grew quadratically with the number of packages. For a program with ~250 packages this took 29s; with one Linker for all of them it takes 8s. The generated code is unchanged.

[joeshaw]

Submitted as a draft until that go-llvm PR lands, as CI can't pass until that happens and this PR is updated to point go.mod at the new commit hash.

[dgryski]

🤖

Each early return has its own linker.Dispose(). A single defer linker.Dispose() right after NewLinker is less error-prone. A defer inside the callback runs at the end of the job function, which is only slightly later than the current explicit call. If the later code in that function needs the Linker disposed before it runs, keep the explicit call.

The error from linker.LinkModule(globalsMod) is ignored. The old llvm.LinkModules(mod, globalsMod) call ignored it too, so this isn't a regression. Checking it would be a cheap improvement

[joeshaw]

Thanks, both done in 08f0674.

[dgryski]

LGTM (once go-llvm fix is merged and this is rebased)