machine: avoid binary size regression after LLVM memory intrinsics#998
Merged
deadprogram merged 1 commit intodevfrom Mar 27, 2020
Merged
machine: avoid binary size regression after LLVM memory intrinsics#998deadprogram merged 1 commit intodevfrom
deadprogram merged 1 commit intodevfrom
Conversation
Somehow moving to LLVM memory intrinsics for calls like memcpy made the machine.sendUSBPacket get inlined. This is a problem because it is called in many different functions and it is just big enough to cause a significant file size increase. Adding //go:noinline solves this problem and gets the examples/blinky1 program below the file size it was before this change (tested: itsybitsy-m0, itsybitsy-m4, circuitplay-bluefruit).
Member
|
Thanks @aykevl now merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somehow moving to LLVM memory intrinsics for calls like memcpy made the
machine.sendUSBPacket get inlined. This is a problem because it is
called in many different functions and it is just big enough to cause a
significant file size increase.
Adding //go:noinline solves this problem and gets the examples/blinky1
program below the file size it was before this change (tested:
itsybitsy-m0, itsybitsy-m4, circuitplay-bluefruit).
This PR fixes the binary size regression seen in #995.