Skip to content

Translate first 6 windows pages in Brazilian Portuguese#2727

Merged
waldyrious merged 9 commits into
tldr-pages:masterfrom
schneiderl:master
Feb 5, 2019
Merged

Translate first 6 windows pages in Brazilian Portuguese#2727
waldyrious merged 9 commits into
tldr-pages:masterfrom
schneiderl:master

Conversation

@schneiderl
Copy link
Copy Markdown
Collaborator

Translated first six windows pages in Portuguese.
List:
cls.md
cmd.md
dir.md
mkdir.md
print.md
type.md

@sbrl sbrl added the translation Issues requesting translating pages from English to other languages. label Jan 23, 2019
Copy link
Copy Markdown
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @schneiderl 😺

@waldyrious / @agnivade, is the language code formatted correctly? I think this is the first one we've got that uses a double-part language code.

@schneiderl
Copy link
Copy Markdown
Collaborator Author

Hi @sbrl

According to the Contributing Guidelines for translation introduced on #2703 language codes should follow BCP 47, just as it is with the files included on this PR.

@agnivade
Copy link
Copy Markdown
Member

Yes, language code is correct. Will leave it to @waldyrious to review.

Comment thread pages.pt-BR/windows/cls.md Outdated
Comment thread pages.pt-BR/windows/dir.md Outdated
Comment thread pages.pt-BR/windows/dir.md Outdated
@waldyrious
Copy link
Copy Markdown
Member

Sorry guys, I've been going through some pretty busy times lately.

@schneiderl, many thanks for the PR! I've added some comments inline, but overall this looks pretty good! Should be ready to merge once the comments are resolved :)

Comment thread pages.pt-BR/windows/mkdir.md Outdated
@schneiderl
Copy link
Copy Markdown
Collaborator Author

Hi @waldyrious ,
I have resolved your comments and it should be good now. :)

Comment thread pages.pt-BR/windows/mkdir.md Outdated
@waldyrious
Copy link
Copy Markdown
Member

One last nitpick :)

Co-Authored-By: schneiderl <casdpa@gmail.com>
@schneiderl
Copy link
Copy Markdown
Collaborator Author

One last nitpick :)

Oh, did not saw that.
Thank you @waldyrious

@waldyrious
Copy link
Copy Markdown
Member

Great, thanks so much for the PR and quick updates :) Given that there's already been two other approvals, I'll go ahead and merge.

@waldyrious waldyrious merged commit 250808d into tldr-pages:master Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translation Issues requesting translating pages from English to other languages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants