Add organization member: @zdroid#3664
Merged
Merged
Conversation
agnivade
approved these changes
Dec 19, 2019
mebeim
requested changes
Dec 19, 2019
owenvoke
approved these changes
Dec 19, 2019
Co-Authored-By: Marco Bonelli <mebeim@users.noreply.github.com>
waldyrious
requested changes
Dec 19, 2019
Member
waldyrious
left a comment
waldyrious
left a comment
There was a problem hiding this comment.
Let's keep the historical record, as discussed previously in #3006.
Contributor
Author
|
@waldyrious Okay, I reverted it. Who is supposed to give the final say, @sbrl maybe? |
waldyrious
approved these changes
Dec 19, 2019
Member
waldyrious
left a comment
waldyrious
left a comment
There was a problem hiding this comment.
LGTM. Welcome at last, @zdroid!
Member
|
I'd say this should only be closed once the invite is sent out and accepted. Any of us with merge permissions can merge once we can verify that you're part of the org (remember that your membership should be public). |
mebeim
approved these changes
Dec 19, 2019
Member
|
Hey! Sorry, I've been busy with wrapping up the end of my first PhD semester. Sending invite now :-) |
Contributor
Author
|
All set, thanks to everyone! |
tansiret
added
the
community
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3663.