lmms, SafeEjectGPU: add pages#5163
Conversation
|
This PR seems to be a bit messed up. |
|
It's cleaned up now. I see the issue. @GingkathFox you opened a PR on your fork (GingkathFox#1) and something (I don't know what) got messed up. To prevent this in the future, run the following commands to update # only run this one if you don't have the upstream remote
git remote add upstream git@github.com:tldr-pages/tldr.git
# update master
git fetch upstream master
git rebase upstream/master
git push origin |
bl-ue
left a comment
There was a problem hiding this comment.
Hi @GingkathFox! I've left some comments below for you to review.
|
@bl-ue is this change good? |
|
@GingkathFox some of the suggestions aren't applied yet. Please apply those first, then I'll review again :) Otherwise, most certainly! |
|
There we go, done :D |
|
oh cool, thanks for another manpage site, ill be sure to check that also in future commits |
sbrl
left a comment
There was a problem hiding this comment.
Note that we've recently made a decision that all filenames should be lowercase if I recall correctly. Could someone open a PR to correct that here please?
|
@sbrl Funny! I forgot about that 😄 @GingkathFox will you please do the honors here? 🙏🏻 |
common/,linux/, etc.)