docker-login: add page#6137
Merged
Merged
Conversation
CleanMachine1
added
the
new command
bl-ue
approved these changes
Jun 17, 2021
navarroaxel
reviewed
Jun 18, 2021
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com>
navarroaxel
reviewed
Jun 18, 2021
navarroaxel
requested changes
Jun 18, 2021
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
Collaborator
Author
|
@navarroaxel Were your suggested changes implemented? I applied all your changes, yet "1 change requested" is still visible. |
marchersimon
suggested changes
Jun 19, 2021
Contributor
@258204 the persons who reject changes need to approve afterwards, or another collaborator needs to dismiss them, in order for that to go away. |
Collaborator
Author
I thought I had accepted all of them though. |
Co-authored-by: marchersimon <50295997+marchersimon@users.noreply.github.com>
Co-authored-by: marchersimon <50295997+marchersimon@users.noreply.github.com>
Co-authored-by: marchersimon <50295997+marchersimon@users.noreply.github.com>
Co-authored-by: marchersimon <50295997+marchersimon@users.noreply.github.com>
navarroaxel
approved these changes
Jun 20, 2021
bl-ue
approved these changes
Jun 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
common/,linux/, etc.)