Skip to content

build fails with python 3.11.0a1 #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
opoplawski opened this issue Nov 3, 2021 · 3 comments · Fixed by #282
Closed

build fails with python 3.11.0a1 #268

opoplawski opened this issue Nov 3, 2021 · 3 comments · Fixed by #282
Labels
bug unintended behaviour in ecdsa code maintenance issues related to making the project usable or testable
Milestone

Comments

@opoplawski
Copy link

python-ecdsa fails to build with Python 3.11.0a1.

Traceback (most recent call last):
  File "/builddir/build/BUILD/ecdsa-0.17.0/setup.py", line 19, in <module>
    version=versioneer.get_version(),
            ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/builddir/build/BUILD/ecdsa-0.17.0/versioneer.py", line 1538, in get_version
    return get_versions()["version"]
           ^^^^^^^^^^^^^^
  File "/builddir/build/BUILD/ecdsa-0.17.0/versioneer.py", line 1465, in get_versions
    cfg = get_config_from_root(root)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/builddir/build/BUILD/ecdsa-0.17.0/versioneer.py", line 346, in get_config_from_root
    parser = configparser.SafeConfigParser()
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'configparser' has no attribute 'SafeConfigParser'. Did you mean: 'RawConfigParser'?

Removed from the configparser module: the SafeConfigParser class, the filename
property of the ParsingError class, the readfp() method of the ConfigParser
class, deprecated since Python 3.2. (Contributed by Hugo van Kemenade in
bpo-45173.)
https://docs.python.org/3.11/whatsnew/3.11.html

@tomato42 tomato42 added this to the v0.18.0 milestone Nov 3, 2021
@tomato42 tomato42 added bug unintended behaviour in ecdsa code maintenance issues related to making the project usable or testable labels Nov 3, 2021
@tomato42
Copy link
Member

tomato42 commented Nov 3, 2021

Thanks for the report, looks like we'll need to extend CI to both 3.10 and 3.11a.
I'll try fixing it before 0.18.0 release, but can't provide a schedule for this.

@hroncok
Copy link

hroncok commented Dec 1, 2021

Updating the bundled versioneer should fix this.

@tomato42
Copy link
Member

tomato42 commented Jan 4, 2022

Updating the bundled versioneer should fix this.

Turns out it's not so simple. versioneer dropped support for python 2 and <3.5, so the generated file needs to be modified.
Secondly, the python itself crashes when running the test suite on py3.11a3: https://github.com/tlsfuzzer/python-ecdsa/runs/4702997032?check_suite_focus=true#step:23:95
Unfortunately I don't have the time now to diagnose what's the cause of that (or if it's not hypothesis or coverage).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unintended behaviour in ecdsa code maintenance issues related to making the project usable or testable
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants