-
Notifications
You must be signed in to change notification settings - Fork 315
try to support pkcs8 v2 format pem file for EdDSA #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
For ed25519 and ed448 in RFC5958, I think it should not raise error if something left after private key. |
Change looks good but there are few nits reported by
|
Of course
|
Furthemore, I want to know if you have rough plan to release version 0.18.0. Then I could use the function for EdDSA. |
black part of |
I think it should be fixed now. |
Yup, looks good. Thanks! |
Try to fix #280.
RFC5958 shows that pkcs8 v2 has the format:
There are maybe optional Attributes and Publickey after Privatekey. Thus it may not raise error when there are trailing data.