Skip to content

Conversation

@lehoffma
Copy link

@lehoffma lehoffma commented Feb 10, 2020

I let the ng update @angular/core @angular/cli migration run on the whole project, which means the demo app now uses Angular 9 too.

lennarth and others added 25 commits February 10, 2020 08:26
…orn-6.4.1

Bump acorn from 6.4.0 to 6.4.1
Bumps [acorn](https://github.com/acornjs/acorn) from 6.4.0 to 6.4.1. **This update includes a security fix.**
- [Release notes](https://github.com/acornjs/acorn/releases)
- [Commits](acornjs/acorn@6.4.0...6.4.1)

Signed-off-by: dependabot-preview[bot] <[email protected]>
…orn-6.4.1

[Security] Bump acorn from 6.4.0 to 6.4.1
…otractor-5.4.3

Bump protractor from 5.4.2 to 5.4.3
…gular-devkit/build-ng-packagr-0.803.25

Bump @angular-devkit/build-ng-packagr from 0.803.21 to 0.803.25
…it-on-4.0.1

Bump wait-on from 3.3.0 to 4.0.1
…pes/node-13.9.1

Bump @types/node from 8.9.5 to 13.9.1
…asmine-core-3.5.0

Bump jasmine-core from 3.4.0 to 3.5.0
…lib-1.11.1

Bump tslib from 1.10.0 to 1.11.1
…arma-jasmine-3.1.1

Bump karma-jasmine from 2.0.1 to 3.1.1
@alexsukhodolsky
Copy link
Contributor

@tnicola please merge this PR ... the current version is preventing anyone from upgrading to angular 10. Thanks!

"polyfills": "projects/demo/src/polyfills.ts",
"tsConfig": "projects/demo/tsconfig.app.json",
"aot": false,
"aot": true,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexsukhodolsky I would be happy to merge it but unfortunately the unit test compilation is failing. Probably due to this change. @lehoffma Can you check this please?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that, but it didn't change the test results for me. The broken unit tests were mostly due to the updated libraries like rxjs I think. I rebased and pushed a fix for the tests, let me know if there's anything else I can do.

@tnicola tnicola merged commit 4a6fa51 into tnicola:master Jul 2, 2020
@tnicola
Copy link
Owner

tnicola commented Jul 2, 2020

@lehoffma PR merged, thanks!A new version of the package has been released: [email protected]

@alexsukhodolsky
Copy link
Contributor

awesome--thanks @tnicola and @lehoffma!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants