fix: blank line at end of requirements file to fix module imports #1043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theymightbetim
commented
Mar 7, 2025
| @@ -1,3 +1,2 @@ | |||
| keyring | |||
| pyotp | |||
| requests | |||
There was a problem hiding this comment.
This package isn't actually required by this module. We need a blank line at the end of the file to prevent concatenation with the next file's requests module.
|
thanks for your efforts! |
Just happy to see all tests passing again :) |
me too, me too :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I broke the test pipeline again with the OTP module because the requirements file was missing a blank line at the end causing it to concatenate the last module in otp.txt with the first module in pihole.txt and then become unable to find a package called pyotprequests instead of installing pyopt and requests.
Sorry about this, I was unable to run the tests before because the pipeline was broken.
Tests Passing Again