Popup calendar module #1046
Merged
Popup calendar module #1046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobi-wan-kenobi
approved these changes
Mar 26, 2025
|
Very nice!!! One suggestion: I think "calendar" would be a nicer name for it, as people would more readily know what it does. What do you think about renaming it? If we can make it backwards compatible, I'd even consider this as a datetimee replacement (but "calendar" might be the better way to go about it) Thank you! |
|
Thanks! still working on tests and cleaning it up, will change it to calendar as well. |
theymightbetim
force-pushed
the
popup-cal
branch
from
7085cb5 to
16413c1
Compare
|
@tobi-wan-kenobi did the rename you suggested and cleaned this up a bunch and added tests. should be ready now. |
|
Looks good, many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended version of datetime module which can display calendar on click and open google calendar on the selected date if you hit enter.