Repository navigation
chore(upstream): refresh zizmor 1.27.0 - #76
Merged
Merged
Conversation
zizmor 1.27 added experimental support for `parallel:` steps, where a steps-list entry nests a list of sub-steps instead of declaring `run:` or `uses:` directly. `build_steps` treated such an entry as an empty step, so template-injection (and every other on_step rule) silently skipped the nested run/uses bodies. This surfaced as a hard upstream-parity divergence on the new `parallel-steps/basic.yml` fixture. Flatten parallel sub-steps into the same StepInfo list under the parent entry's step_index so on_step rules see them; diagnostics for a nested sub-step fall back to the parent parallel: entry's position.
Contributor
Author
|
Preview Worker |
There was a problem hiding this comment.
Pull request overview
Updates the repository’s pinned zizmor upstream to v1.27.0 and adapts karinto’s step modeling to support zizmor’s new experimental parallel: step groups so per-step rules continue to analyze nested run:/uses: bodies.
Changes:
- Bumped zizmor pin to 1.27.0 (tooling + refresh metadata) and re-vendored upstream fixtures/snapshots.
- Updated
build_stepsto flattenparallel:sub-steps intoStepInfoentries (sharing the parent’sstep_index) soon_steprules can inspect them. - Added a regression test and a changeset to cover
template-injectionfiring within aparallel:sub-step.
Reviewed changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
rules.mbt |
Flattens parallel: sub-steps into the step list so per-step rules (e.g., template injection) see nested run:/uses:. |
zizmor_rules_test.mbt |
Adds a regression test asserting template-injection triggers within a parallel: sub-step (and matches expected diagnostic shape). |
mise.toml |
Bumps the ubi:zizmorcore/zizmor tool pin to 1.27.0. |
refresh-summary.json |
Updates the auto-generated refresh metadata for zizmor 1.27.0 (tag/URLs/notes). |
pr-body.md |
Updates the auto-generated PR body snippet for zizmor 1.27.0 release notes/compare link. |
fixtures/upstream/zizmor/** |
Re-vendored zizmor 1.27.0 fixtures, including new parallel-steps test data and updated snapshots. |
.changeset/step-into-parallel-steps.md |
Documents the user-visible fix for per-step rules missing findings inside parallel: steps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parallel:steps (a steps-list entry nesting a list of sub-steps instead of declaringrun:/uses:directly) were invisible to karinto's step model.build_stepstreated aparallel:entry as an empty step, sotemplate-injection(and every otheron_steprule) silently skipped the nestedrun:/uses:bodies — this showed up as a hardupstream-paritydivergence on the newly-vendoredparallel-steps/basic.ymlfixture.build_steps(rules.mbt) now flattensparallel:sub-steps into the sameStepInfolist under the parent entry'sstep_index, soon_steprules see them. Diagnostics for a nested sub-step fall back to reporting the parentparallel:entry's position (consistent with the existing "position never lost" fallback semantics inpositions.mbt).zizmor_rules_test.mbt) coveringtemplate-injectioninside aparallel:sub-step, and a changeset.moon test(259/259 passing),moon info(no.mbtichange), andscripts/upstream-parity/compare.mjsagainst the pinned zizmor 1.27.0 toolchain (0 hard divergences,parallel-steps/basic.ymlno longer listed as missing).Refresh upstream linter pins (auto-generated).
v1.26.1...v1.27.0Fixtures under
fixtures/upstream/<tool>/were re-vendored from the new tag. This PR is opened withGITHUB_TOKEN, soupstream-paritydoes not run automatically — add therun-paritylabel to trigger it. Its step summary then lists any divergences (unmapped/ soft) that point at newly-added upstream checks.Upstream release notes
zizmor v1.27.0
New Features 🌈🔗
zizmor now has experimental support for workflows that specify parallel steps. See Usage - Parallel steps for more information (#2153)
Enhancements 🌱🔗
zizmor's handling of paths is now more consistent, particularly when run on Windows (#2163)
zizmor now emits a helpful warning when being run in implicit offline mode (#2180)
Bug Fixes 🐛🔗
Fixed a bug where the secrets-outside-env audit would not honor ignore comments within the same job scope (#2157)
Fixed a bug where the ref-version-mismatch audit would not honor ignore comments within the same steps scope (#2177)
Fixed a bug where
--collect=[MODE]was not correctly handled when auditing remote inputs (#2185)Incorporation checklist
If the parity step summary surfaces an
unmapped/ soft divergence (an upstream check karinto does not yet cover), follow the incorporation flow inDEVELOPMENT.md:comparediff + release notes above for new / changed checks.run-paritylabel and checked theupstream-paritystep summary forunmappedrule IDs / Kinds.rules_catalog.mbt(+ mirroredrules_catalog.md) with a status, or recorded the intentional divergence inscripts/upstream-parity/allowlist.json.moon test+ local parity pass.