Skip to content

chore(upstream): refresh zizmor 1.27.0 - #76

Merged
toiroakr merged 2 commits into
mainfrom
chore/upstream-refresh
Jul 21, 2026
Merged

toiroakr merged 2 commits into
mainfrom
chore/upstream-refresh

Conversation

@github-actions

@github-actions github-actions Bot commented Jul 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Fixed a CI regression surfaced by this refresh: zizmor 1.27's new experimental parallel: steps (a steps-list entry nesting a list of sub-steps instead of declaring run:/uses: directly) were invisible to karinto's step model. build_steps treated a parallel: entry as an empty step, so template-injection (and every other on_step rule) silently skipped the nested run:/uses: bodies — this showed up as a hard upstream-parity divergence on the newly-vendored parallel-steps/basic.yml fixture.
  • Fix: build_steps (rules.mbt) now flattens parallel: sub-steps into the same StepInfo list under the parent entry's step_index, so on_step rules see them. Diagnostics for a nested sub-step fall back to reporting the parent parallel: entry's position (consistent with the existing "position never lost" fallback semantics in positions.mbt).
  • Added a regression test (zizmor_rules_test.mbt) covering template-injection inside a parallel: sub-step, and a changeset.
  • Verified locally: moon test (259/259 passing), moon info (no .mbti change), and scripts/upstream-parity/compare.mjs against the pinned zizmor 1.27.0 toolchain (0 hard divergences, parallel-steps/basic.yml no longer listed as missing).

Refresh upstream linter pins (auto-generated).

tool from to release compare
zizmor 1.26.1 1.27.0 v1.27.0 v1.26.1...v1.27.0

Fixtures under fixtures/upstream/<tool>/ were re-vendored from the new tag. This PR is opened with GITHUB_TOKEN, so upstream-parity does not run automatically — add the run-parity label to trigger it. Its step summary then lists any divergences (unmapped / soft) that point at newly-added upstream checks.

Upstream release notes

zizmor v1.27.0

New Features 🌈🔗

  • zizmor now has experimental support for workflows that specify parallel steps. See Usage - Parallel steps for more information (#2153)
    Enhancements 🌱🔗

  • zizmor's handling of paths is now more consistent, particularly when run on Windows (#2163)

  • zizmor now emits a helpful warning when being run in implicit offline mode (#2180)

Bug Fixes 🐛🔗

  • Fixed a bug where the secrets-outside-env audit would not honor ignore comments within the same job scope (#2157)

  • Fixed a bug where the ref-version-mismatch audit would not honor ignore comments within the same steps scope (#2177)

  • Fixed a bug where --collect=[MODE] was not correctly handled when auditing remote inputs (#2185)

Incorporation checklist

If the parity step summary surfaces an unmapped / soft divergence (an upstream check karinto does not yet cover), follow the incorporation flow in DEVELOPMENT.md:

  • Reviewed the compare diff + release notes above for new / changed checks.
  • Added the run-parity label and checked the upstream-parity step summary for unmapped rule IDs / Kinds.
  • For each new check: registered it in rules_catalog.mbt (+ mirrored rules_catalog.md) with a status, or recorded the intentional divergence in scripts/upstream-parity/allowlist.json.
  • moon test + local parity pass.

@github-actions github-actions Bot added dependencies Pull requests that update a dependency file skip-changeset Bypass the changeset CI gate for PRs with no user-visible impact labels Jul 20, 2026
zizmor 1.27 added experimental support for `parallel:` steps, where a
steps-list entry nests a list of sub-steps instead of declaring `run:`
or `uses:` directly. `build_steps` treated such an entry as an empty
step, so template-injection (and every other on_step rule) silently
skipped the nested run/uses bodies. This surfaced as a hard
upstream-parity divergence on the new `parallel-steps/basic.yml`
fixture.

Flatten parallel sub-steps into the same StepInfo list under the
parent entry's step_index so on_step rules see them; diagnostics for a
nested sub-step fall back to the parent parallel: entry's position.
@github-actions

github-actions Bot commented Jul 21, 2026 •

Copy link
Copy Markdown
Contributor Author

Preview Worker karinto-pr-76 has been deleted.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s pinned zizmor upstream to v1.27.0 and adapts karinto’s step modeling to support zizmor’s new experimental parallel: step groups so per-step rules continue to analyze nested run:/uses: bodies.

Changes:

  • Bumped zizmor pin to 1.27.0 (tooling + refresh metadata) and re-vendored upstream fixtures/snapshots.
  • Updated build_steps to flatten parallel: sub-steps into StepInfo entries (sharing the parent’s step_index) so on_step rules can inspect them.
  • Added a regression test and a changeset to cover template-injection firing within a parallel: sub-step.

Reviewed changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.

Show a summary per file
File Description
rules.mbt Flattens parallel: sub-steps into the step list so per-step rules (e.g., template injection) see nested run:/uses:.
zizmor_rules_test.mbt Adds a regression test asserting template-injection triggers within a parallel: sub-step (and matches expected diagnostic shape).
mise.toml Bumps the ubi:zizmorcore/zizmor tool pin to 1.27.0.
refresh-summary.json Updates the auto-generated refresh metadata for zizmor 1.27.0 (tag/URLs/notes).
pr-body.md Updates the auto-generated PR body snippet for zizmor 1.27.0 release notes/compare link.
fixtures/upstream/zizmor/** Re-vendored zizmor 1.27.0 fixtures, including new parallel-steps test data and updated snapshots.
.changeset/step-into-parallel-steps.md Documents the user-visible fix for per-step rules missing findings inside parallel: steps.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@toiroakr
toiroakr merged commit 6af3505 into main Jul 21, 2026
12 checks passed
@toiroakr
toiroakr deleted the chore/upstream-refresh branch July 21, 2026 05:40
@github-actions github-actions Bot mentioned this pull request Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file skip-changeset Bypass the changeset CI gate for PRs with no user-visible impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants