Skip to content

Added Snippet to generate key id #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
odose-token wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added Snippet to generate key id #72

odose-token wants to merge 1 commit into from

Conversation

@odose-token
Copy link
Contributor

@odose-token odose-token commented Dec 7, 2020

No description provided.

paul-smith-token-io
paul-smith-token-io reviewed Dec 7, 2020
View reviewed changes
Copy link

@paul-smith-token-io paul-smith-token-io left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that you've half done the job here.
It is certainly the correct algorithm, but you have copied the algorithm in this library code.
However, that means that we are now supporting the same algorithm in two places - that seems very inefficient.

I think that it would be far better to simply call the library method from within your new test case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@paul-smith-token-io paul-smith-token-io paul-smith-token-io left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@odose-token @paul-smith-token-io