Fix color picker on manual hex code entry #703
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When manually entering a hex color code in the graph editor's color picker, the application would display an error message "something went wrong" instead of accepting the input.
Root Cause
The issue occurred because the
hexToColor
function was not handling errors when creating a Color object from an invalid or incomplete hex string. When the user was typing a value (which could be temporarily invalid during typing), this would cause an unhandled exception to be thrown.Solution
Added proper validation and error handling in two key locations:
In the
ColorField
component:isValidHexColor
function to validate hex color formatonChange
handler to validate input before conversionIn the
hexToColor
utility function:Testing
Tested manually by entering various hex codes, including:
The color picker now accepts valid input and gracefully handles invalid input without error messages.
Fixes #702.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
telemetry.nextjs.org
/opt/hostedtoolcache/node/20.19.1/x64/bin/node /home/REDACTED/work/graph-engine/graph-engine/packages/ui/node_modules/.bin/next build
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.