Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
strict
version ofcheckAndEvaluateMath
which is being evaluated by https://github.com/tokens-studio/unit-Calculator/This will allow users to specify stricter rules on which units they want to mix, in the case of Penpot only rem and px units are allowed as units and to mix with a predefined conversion value.
Besides doing proper unit parsing, it also gets rid of a bunch of wrapped regexes around expr-eval-fork that try to do things like group splitting, removing and putting back of units, etc. Instead a proper parser will be used to evaluate expressions.
There are a bunch of functions in expr-eval that we might want to restore, I've added an example with
roundTo
here:sd-transforms/src/strictCheckAndEvaluateMath.ts
Line 12 in 9b27a73
strict math can be enabled by setting
mathOptions
in the platform config.