Add support for lock_api #161
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds Loom mock implementations of the `lock_api::RawMutex` and `lock_api::RawRwLock` traits, as well as re-exports for the relevant concrete types, gated behind a `"lock_api"` feature. The `parking_lot` and `lock_api` crates provide a slightly different interface than the standard library interface to `Mutex` and `RwLock`, which can make them difficult or impossible to test using `sync::Mutex` and `sync::RwLock` mocks.
mystor
commented
Jul 26, 2020
Comment on lines
+17
to
+22
| // Unfortunately, we're required to have a `const INIT` in order to | ||
| // implement `lock_api::RawMutex`, so we need to lazily create the actual | ||
| // `rt::Mutex`. | ||
| fn object(&self) -> &rt::Mutex { | ||
| self.object.get_or_init(|| rt::Mutex::new(true)) | ||
| } |
Author
There was a problem hiding this comment.
I couldn't think of a cleaner way to satisfy this requirement, so I threw in a OnceCell.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Loom mock implementations of the
lock_api::RawMutexandlock_api::RawRwLocktraits, as well as re-exports for the relevant concrete types, gated behind a"lock_api"feature.The
parking_lotandlock_apicrates provide a slightly different interface than the standard library interface toMutexandRwLock, which can make them difficult or impossible to test usingsync::Mutexandsync::RwLockmocks.