Adding wait_while to the loom Condvar.
#167
Conversation
…ined with the existing wait, so I lifted the wait_while function body straight from the rust implementation
| /// Blocks the current thread until this condition variable receives a | ||
| /// notification and the given condition returns false. |
There was a problem hiding this comment.
Nit, take it or leave it: we could just copy and paste the entire doc comment from std::sync::Condvar here, since the API is identical. But, it doesn't really matter (and it looks like other methods on our mock Condvar don't reproduce the entire std comment...
There was a problem hiding this comment.
I thought about that, but yeah. It didn't seem like that would fit in with the existing comments that were there.
| &self, | ||
| mut guard: MutexGuard<'a, T>, | ||
| mut condition: F, | ||
| ) -> LockResult<MutexGuard<'a, T>> |
There was a problem hiding this comment.
I wonder if we could elide these?
There was a problem hiding this comment.
No, I tried. Eliding the lifetime completely gives a warning because it’s part of the MutexGuard struct. Trying to make it anonymous gives a complete error because it tries to use the same lifetime as &self.
Also messing with signature seems like a bad idea since we’re trying match what’s in std.
|
Are there any blocking issues for this PR? I appreciate that we can use this API in loom. Thank you! |
4 participants
This is just some logic combined with the existing wait, so I lifted the actual wait_while matches exactly what the std::rust implementation does