List accessors even without locations #279
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kriskras99
added a commit
to Kriskras99/ringbeam
that referenced
this pull request
Jul 10, 2025
Loom throws an unclear (and hopefully wrong) error for all the
interleaved tests. It seems to think that the write reference to
the UnsafeCell lasts longer than it does:
```
Causality violation: Concurrent read and write accesses.
created: /home/kriskras99/Source/ringbeam/src/ring/mod.rs:126:21
read: thread #1 @ /home/kriskras99/Source/ringbeam/src/ring/recv_values.rs:72:63
```
With [PR loom#279](tokio-rs/loom#279) it also
shows a write in thread #1 but without a location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves #260 and #278 but doesn't resolve them. At least it doesn't completely skip the other accesses now. It only misses their locations, and I don't know why they are not captured.