prost-build: Extract file descriptor loading from compile_protos() #1067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caspermeijn
requested changes
May 31, 2024
Contributor
caspermeijn
left a comment
caspermeijn
left a comment
There was a problem hiding this comment.
I would like to see a test that actually uses this. Maybe you could edit an existing test to do some introspection?
prost-build/src/config.rs
Outdated
| /// let mut config = Config::new(); | ||
| /// let file_descriptor_set = config.load_fds(&["src/frontend.proto", "src/backend.proto"], &["src"])?; | ||
| /// | ||
| /// // Inspect file_descriptor_set and tweak config |
Contributor
There was a problem hiding this comment.
Can you change this to a concrete example?
Co-authored-by: Casper Meijn <[email protected]>
Contributor
Author
|
@caspermeijn Thanks for the review. I've added a usage example in the |
caspermeijn
approved these changes
Jul 19, 2024
Contributor
caspermeijn
left a comment
caspermeijn
left a comment
There was a problem hiding this comment.
Thank you for your contribution
Contributor
Author
|
Thanks @caspermeijn! What is the next step for this PR to be merged? |
Contributor
There you go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts the file descriptor loading part from
prost_build::compile_protos()to a newprost_build::load_fds()function.This allows inspection or even modification of descriptors before calling
prost_build::compile_fds. Possible use cases include generating additional files from the descriptors, or set computedConfigattributes by introspecting what is actually present in the.protofiles before generating the code.