feat(prost-build): emit rerun commands
#1140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inform `cargo` about the files and env vars used by `prost-build`. Then `cargo` can better determine when to rebuild a project. - Emit `rerun-if-changed` for each proto file specified - Emit `rerun-if-changed` for each include directory specified - Emit `rerun-if-changed` if `file_descriptor_set_path` is set - Emit `rerun-if-env-changed` for `PROTOC` and `PROTOC_INCLUDE` https://doc.rust-lang.org/cargo/reference/build-scripts.html#rerun-if-changed BREAKING CHANGE: Previously `cargo` assumed it had to rerun `build.rs` if any files in the project changed. `prost-build` will now emit `rerun` commands, which means only the explicitly marked files cause a rerun. If your `build.rs` is dependent on any other file paths than those given to `prost-build`, then your `build.rs` needs to emit `rerun` commands as well.
caspermeijn
force-pushed
the
rerun_if_changed
branch
from
b4c8112 to
cdccb41
Compare
|
Would really appreciate this feature! |
caspermeijn
added a commit
to caspermeijn/prost
that referenced
this pull request
Jun 17, 2025
This reverts commit 7c16959. In version 0.14.0, `prost-build` began emitting `rerun` commands. This change introduced regressions for some users—for example, those generating `protos` from an `includes` directory. These edge cases are non-trivial to address comprehensively, so version 0.14.1 reverts the emission of `rerun` commands. For more details, see issue tokio-rs#1296.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 17, 2025
This reverts commit 7c16959. In version 0.14.0, `prost-build` began emitting `rerun` commands. This change introduced regressions for some users—for example, those generating `protos` from an `includes` directory. These edge cases are non-trivial to address comprehensively, so version 0.14.1 reverts the emission of `rerun` commands. For more details, see issue #1296.
ianoc
pushed a commit
to ianoc/prost
that referenced
this pull request
Oct 22, 2025
…kio-rs#1297) This reverts commit 7c16959. In version 0.14.0, `prost-build` began emitting `rerun` commands. This change introduced regressions for some users—for example, those generating `protos` from an `includes` directory. These edge cases are non-trivial to address comprehensively, so version 0.14.1 reverts the emission of `rerun` commands. For more details, see issue tokio-rs#1296.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inform
cargoabout the files and env vars used byprost-build. Thencargocan better determine when to rebuild a project.rerun-if-changedfor each proto file specifiedrerun-if-changedfor each include directory specifiedrerun-if-changediffile_descriptor_set_pathis setrerun-if-env-changedforPROTOCandPROTOC_INCLUDEhttps://doc.rust-lang.org/cargo/reference/build-scripts.html#rerun-if-changed
BREAKING CHANGE: Previously
cargoassumed it had to rerunbuild.rsif any files in the project changed.prost-buildwill now emitreruncommands, which means only the explicitly marked files cause a rerun. If yourbuild.rsis dependent on any other file paths than those given toprost-build, then yourbuild.rsneeds to emitreruncommands as well.