fix(prost-build): Make type_name_domain cumulative
#1228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caspermeijn
approved these changes
Feb 3, 2025
Contributor
caspermeijn
left a comment
caspermeijn
left a comment
There was a problem hiding this comment.
I agree, this makes more sense. Thanks for your contribution.
This is a breaking change, so it has to wait for the next major release.
BREAKING CHANGE: The configuration for domain names of messages is now cumulative. All calls to
prost_build::Config::type_name_domainare now concatinated. The previous behaviour is that only the arguments of the last call was used. If you do multiple calls totype_name_domain, you need to remove all but the last call to maintain the same behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the
type_name_domainconfig to behave closer to the wayextern_pathdoes.This allows setting more than 1 path to domain mappings.
The original behavior of clearing previous mappings didn't make a lot of sense to me, but perhaps it was working as intended. If that's the case, then this would be a feature instead of a fix I guess.
BREAKING CHANGE: The configuration for domain names of messages is now cumulative. All calls to prost_build::Config::type_name_domain are now concatenated. The previous behavior was that only the arguments of the last call were used. If you do multiple calls to type_name_domain, you need to remove all but the last call to maintain the same behavior.