Config option to use proto enums as Rust enums - #1278
Open
tkr-sh wants to merge 11 commits into
Open
Conversation
Author
|
This might be a partial fix to #276 btw |
|
Related PR: #1079 |
Author
|
Yes! But this one is really easy to implement since it keeps the same declaration of enums, it's just that the types used in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, protos
enums are converted to Rusti32. Which can be annoying / not convenient.I created a new
Configfield -proto_enum_to_rust_enum- that, when activated, converts proto'senums into Rust'senuminstead ofi32,The data transferred over the wire is exactly the same as
i32. (See:prost-derive/src/field/enum_typed.rs)Not sure where to put the test in
prost-build/src/code_generator.rs?