feat: Add support for Arc<str> as a string type #1355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
force-pushed
the
claude/add-arc-str-support-011CUuUXih8LqeVCVxAvJVQK
branch
4 times, most recently
from
5bba936 to
4924007
Compare
alex
force-pushed
the
claude/add-arc-str-support-011CUuUXih8LqeVCVxAvJVQK
branch
from
4924007 to
72fc9bc
Compare
This is modeled on the support for multiple types for bytes.
alex
force-pushed
the
claude/add-arc-str-support-011CUuUXih8LqeVCVxAvJVQK
branch
from
72fc9bc to
acb3d7a
Compare
Author
|
Understanding the new maintenance policy, I'm hoping this counts as a small improvement (and thus is under consideration), rather than a new feature :-) If there's anything I can do to make this easier to review, please don't hesitate to ask. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is modeled on the support for multiple types for bytes.