-
Notifications
You must be signed in to change notification settings - Fork 140
chore: Update dependencies and fix clippy warnings #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore: Update dependencies and fix clippy warnings #327
Conversation
Due to rust-lang/rust#124210, when an owned fd has already been closed before it's dropped means that something else touched the fd in ways its not allowed to. Therefore, these tests fail due to this new behavior enforcement Signed-off-by: Bryant Biggs <[email protected]>
cc @Noah-Kennedy if you have a few cycles to review |
Drive-by review: I don't think bumping patch versions of dependencies makes sense unless the older versions have a serious security vulnerability, are completely broken or break |
@paolobarbolini what are the downsides of bumping the patch versions? |
The inflexibility of not being able to update things at my own pace, which for me personally I try to update things frequently, but if I have to revert to a previous version I don't want to have to downgrade or fork a second dependency just because the minimum allowed version was bumped too high. |
@bryantbiggs Great contribution! Were you able to revert the unnecessary patch versions? I updated everything to latest (nix 0.30) while only specifying minor versions (removing the patch digit). diff --git a/Cargo.toml b/Cargo.toml
index 62fbef5..92376cf 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -17,22 +17,22 @@ keywords = ["async", "fs", "io-uring"]
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
[dependencies]
-tokio = { version = "1.44", features = ["net", "rt", "sync"] }
-slab = "0.4.9"
-libc = "0.2.171"
-io-uring = "0.7.4"
-socket2 = { version = "0.5.9", features = ["all"] }
-bytes = { version = "1.10.1", optional = true }
-futures-util = { version = "0.3.31", default-features = false, features = ["std"] }
+tokio = { version = "1.2", features = ["net", "rt", "sync"] }
+slab = "0.4.2"
+libc = "0.2.80"
+io-uring = "0.7"
+socket2 = { version = "0.5", features = ["all"] }
+bytes = { version = "1.0", optional = true }
+futures-util = { version = "0.3.26", default-features = false, features = ["std"] }
[dev-dependencies]
-tempfile = "3.19.1"
-tokio-test = "0.4.4"
+tempfile = "3.2.0"
+tokio-test = "0.4.2"
iai = "0.1.1"
-criterion = "0.5.1"
+criterion = "0.5"
# we use joinset in our tests
-tokio = "1.44.2"
-nix = { version = "0.29.0", features = ["resource"] }
+tokio = "1.21.2"
+nix = { version = "0.30", features = ["resource"] }
[package.metadata.docs.rs]
all-features = true For reference to master: diff --git a/Cargo.toml b/Cargo.toml
index 85ce27d..92376cf 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -20,8 +20,8 @@ keywords = ["async", "fs", "io-uring"]
tokio = { version = "1.2", features = ["net", "rt", "sync"] }
slab = "0.4.2"
libc = "0.2.80"
-io-uring = "0.6.0"
-socket2 = { version = "0.4.4", features = ["all"] }
+io-uring = "0.7"
+socket2 = { version = "0.5", features = ["all"] }
bytes = { version = "1.0", optional = true }
futures-util = { version = "0.3.26", default-features = false, features = ["std"] }
@@ -29,10 +29,10 @@ futures-util = { version = "0.3.26", default-features = false, features = ["std"
tempfile = "3.2.0"
tokio-test = "0.4.2"
iai = "0.1.1"
-criterion = "0.4.0"
+criterion = "0.5"
# we use joinset in our tests
tokio = "1.21.2"
-nix = "0.26.1"
+nix = { version = "0.30", features = ["resource"] }
[package.metadata.docs.rs]
all-features = true |
@paolobarbolini / @reneleonhardt done! @Noah-Kennedy any thoughts on the changes? |
due to this new behavior enforcement
CI tests were executed on fork first to ensure tests pass https://github.com/bryantbiggs/tokio-uring/actions/runs/14344438841?pr=1
Closes #324
Closes #313
Closes #272
Resolves #316