time: Eagerly bind delays to timer #1800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carllerche
requested changes
Nov 20, 2019
Member
carllerche
left a comment
carllerche
left a comment
There was a problem hiding this comment.
Looks great. One smallish request re: reverting a mostly unrelated change.
| pub(crate) fn set_default(handle: &Handle) -> DefaultGuard<'_> { | ||
| CURRENT_TIMER.with(|current| { | ||
| let mut current = current.borrow_mut(); | ||
| let prev = current.take(); |
Member
There was a problem hiding this comment.
I think this should be reverted and punted to a separate discussion. I was working on allowing re-entry (and I think some tests need it). Re-entry is needed since there are no more APIs that take handles, so it is the only way to use a custom timer.
Signed-off-by: Kevin Leimkuhler <[email protected]>
Signed-off-by: Kevin Leimkuhler <[email protected]>
Signed-off-by: Kevin Leimkuhler <[email protected]>
kleimkuhler
force-pushed
the
kleimkuhler/eager-timer-registration
branch
from
e505717 to
98b102a
Compare
kleimkuhler
added a commit
that referenced
this pull request
Dec 5, 2019
## Motivation #1800 removed the lazy binding of `Delay`s to timers. With the removal of the logic required for that, `HandlePriv` is no longer needed. This PR removes the use of `HandlePriv`. A `TODO` was also removed that would panic if when registering a new `Delay` the current timer handle was full. That has been fixed to now immediately transition that `Delay` to an error state that can be handled in a similar way to other error states. Signed-off-by: Kevin Leimkuhler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Similar to #1666, it is no longer necessary to lazily register delays with the
executions default timer. All delays are expected to be created from within a
runtime, and should panic if not done so.
Solution
tokio::timenow assumes there to be aCURRENT_TIMERset when creating adelay; this can be assumed if called within a tokio runtime. If there is no
current timer, the application will panic with a "no current timer" message.
Follow-up
Similar to #1666,
HandlePrivcan probably be removed, but this mainly preparesfor 0.2 API changes. Because it is not in the public API, this can be done in a
following change.
Signed-off-by: Kevin Leimkuhler [email protected]