tracing-subscriber: change try_init error type to TryInitError
#2158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Seems fine to me, I think we'll have to wait to merge until we're ready to release tracing-subscriber 0.4 though (I assigned the relevant Milestone for now) |
Member
|
Yeah, I'm fine with adding a named error type, but this will require waiting for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2157
Motivation
My main motivation was to improve the user-experience by returning a more concrete error type without a
Boxaround it, which makes it more compatible with other error types, likeanyhow::Result.Solution
The solution is simple, just change the error type. I'm assuming that this PR is still a problem, because it might count as a breaking change?