Use variadic tuples in Promise.all #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

tom-sherman wants to merge 1 commit into master from promise-all-variadic-tuples

Owner

tom-sherman commented Jul 28, 2020

Fixes microsoft#39788

I've changed the Promise.all function to use variadic tuples. Example:

declare const foo: Promise<string>;
declare const bar: Promise<number>[];

declare interface PromiseConstructor {
    all<T extends readonly unknown[]>(values: [...T]): { [P in keyof T]: T[P] extends Promise<infer U> ? U : never }
}

async function m() {
    const p = await Promise.all([
        foo,
        ...bar
    ])
}

Playground link


          Use variadic tuples in Promise.all

34103c9

tom-sherman closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet