Update to Bootstrap Icons 11.1.1 and upgrade to Typescript 5 #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommyip
reviewed
Oct 4, 2023
Owner
tommyip
left a comment
tommyip
left a comment
There was a problem hiding this comment.
Thanks for the work, just some minor comments.
| @@ -1,44 +1,44 @@ | |||
| import typescript from 'rollup-plugin-typescript2'; | |||
| import { terser } from 'rollup-plugin-terser'; | |||
| import terser from "@rollup/plugin-terser"; | |||
Contributor
Author
There was a problem hiding this comment.
Sure, we can change it, if u like. I just used my Prettier in VSCode to do some code styling. Maybe we should create a prettier conf to keep the styling streamlined.
| }, | ||
| "scripts": { | ||
| "build": "node ./src/codegen.js && rollup -c", | ||
| "build": "node ./src/codegen.cjs && rollup -c", |
Owner
There was a problem hiding this comment.
Is there a need to add "type": "module", and cjs?
Contributor
Author
There was a problem hiding this comment.
Not sure, i had some issues with the migration to typescript 5 and rollup, could be a change that is not needed.
Owner
|
Released to npm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.