Skip to content

[BUG] fix disable suggestion bug#2

Open
tomoikey wants to merge 2 commits intomasterfrom
fix/disable-suggestion-bug
Open

[BUG] fix disable suggestion bug#2
tomoikey wants to merge 2 commits intomasterfrom
fix/disable-suggestion-bug

Conversation

@tomoikey
Copy link
Copy Markdown
Owner

@tomoikey tomoikey commented Dec 25, 2024

First, please allow me to offer my apologies. I have realized that a minor bug exists in the Pull Request I previously submitted.

The issue is that when disableSuggestion is set to true, and consecutive queries are made, the resulting error messages are duplicated.

Below, I’ve included a screenshot that demonstrates the bug, along with steps to reproduce it. Please feel free to try it out in your local playground environment:

  1. Set disableSuggestion to true.
  2. Execute a query that would normally trigger suggestions.
  3. Observe that the errors are outputted multiple times, creating duplicates.

Previous Pull Request

99designs#3411

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@tomoikey tomoikey changed the title [BUG] Fix disable suggestion bug [BUG] fix disable suggestion bug Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant