expose TsMrangeEntry to users #19
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not having the
TsMrangeEntryexposed to users of the library makes it impossible to manually create instances ofTsMrange. This makes testing difficult as theTsMrangecannot be mocked. To test functions that return something likeVec<TsMrange<u64, f64>>(an mrange from each shard in a cluster), you have to do something like change the return type toVec<Vec<Timeseries>>whereTimeseriesis a new struct. Then you are forced to copy all theTsMrangeEntryvalues over to these new structs, which is a wildly unnecessary performance hit.I see that
TsMrangeEntryis alreadypublicso I'm hoping someone simply forgot to addpub useit!