Skip to content

Conversation

@SpyCheese
Copy link
Member

proto_version was passed there for consensus reasons and is not needed anymore. Removing this simplifies code.

@github-actions
Copy link

Findings

  • Medium – Backward compatibility risk: collated data is now always serialized/deserialized with BOC mode 2, dropping the proto-version switch that previously used mode 31 for proto_version < 5 (validator/impl/collator.cpp:6414, validator-session/candidate-serializer.cpp:136-138, validator/collator-node/utils.cpp:66-83). If any nodes still run with proto_version < 5 or have stored candidates hashed with the old mode, mixed-version collation will produce different collated-data bytes/hashes and fail to interoperate. Please confirm the minimum supported proto_version or gate this behavior with a protocol bump.

@EmelyanenkoK EmelyanenkoK merged commit 95747d3 into testnet Dec 15, 2025
36 of 37 checks passed
@SpyCheese SpyCheese deleted the serialize-patch branch December 15, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants