Skip to content

[$10][MSFT-186] [Challenge Feed][NVD] Facebook icon is not properly read-out by the screen reader #2854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
veshu opened this issue Jul 17, 2019 · 34 comments

Comments

@veshu
Copy link
Contributor

veshu commented Jul 17, 2019

Steps to Reproduce

  1. Go to https://www.topcoder.com/challenges/30095347/?type=develop&nocache=true
  2. Hover over the Facebook icon

Expected Result
It should be "Icon Facebook"

Actual Result
Read-out as "f"

Device: Desktop/Labtop
Operating System: Windows
Browser: Chrome

WCAG Category: 1. Perceivable
WCAG Level: A
WCAG Success Criterion: 1.3.1 Info and Relationships
Screen Reader Used: Other
Accessibility Audit Tool used: N/A

Attachment
https://topcodermsft-my.sharepoint.com/personal/pd-topcoder_topcodermsft_onmicrosoft_com/Documents/Forms/All.aspx?cid=58da9b68%2Df2a3%2D45d2%2Dbbae%2D15abdfd0865b&FolderCTID=0x0120005C598A51049FC14CBA882E1AEE168F51&sortField=Modified&isAscending=true&id=%2Fpersonal%2Fpd%2Dtopcoder%5Ftopcodermsft%5Fonmicrosoft%5Fcom%2FDocuments%2FMSFT%2DTeams%2DQA%2FJune%202019%2F29%20Jun%2FTest%20Results%2FBug%20Videos%20%26%20Log%20Files%2Fcodejam%2DAccessibility%2F65

@veshu veshu changed the title [MSFT-186] [Challenge Feed][NVD] Facebook icon is not properly read-out by the screen reader [$10][MSFT-186] [Challenge Feed][NVD] Facebook icon is not properly read-out by the screen reader Jul 18, 2019
@ThomasKranitsas
Copy link
Contributor

Contest https://www.topcoder.com/challenges/30096063 has been created for this ticket.

This is an automated message for thomaskranitsas via Topcoder X

@ThomasKranitsas
Copy link
Contributor

Contest https://www.topcoder.com/challenges/30096063 has been updated - the new changes has been updated for this ticket.

This is an automated message for thomaskranitsas via Topcoder X

@r0hit-gupta
Copy link
Collaborator

Please assign me

@ThomasKranitsas
Copy link
Contributor

Contest https://www.topcoder.com/challenges/30096063 has been updated - it has been assigned to rohitgupta_.

This is an automated message for thomaskranitsas via Topcoder X

@veshu
Copy link
Contributor Author

veshu commented Jul 18, 2019

@r0hit-gupta Please use changes for #xxxx style of commit message instead of fix(s) ....

@veshu
Copy link
Contributor Author

veshu commented Jul 18, 2019

@r0hit-gupta Also please use qa-accessibility branch.

@veshu
Copy link
Contributor Author

veshu commented Jul 19, 2019

@r0hit-gupta Please fix the #2914

@r0hit-gupta
Copy link
Collaborator

@veshu done.

@codeMinter
Copy link
Contributor

@r0hit-gupta we will need a new PR for this, using qa-accessibility as base. I changed the base on PR and see huge lot of changes.

@r0hit-gupta
Copy link
Collaborator

@gurmeetb sure. Working on it

@r0hit-gupta r0hit-gupta mentioned this issue Jul 19, 2019
@r0hit-gupta
Copy link
Collaborator

New PR #2964

@anonymousjaggu
Copy link
Collaborator

@r0hit-gupta please check the comment in MR

@crazyk07 crazyk07 removed the On hold label Jul 30, 2019
@tosha5252
Copy link

@sushilshinde still getting the same thing, not working for me in Chrome

@tosha5252 tosha5252 added QA Failed on Prod Fail on Production and removed Ready for Prod QA labels Jul 30, 2019
@sushilshinde
Copy link
Collaborator

sushilshinde commented Jul 30, 2019

@crazyk07 @tosha5252 @lakshmiathreya @drasticdpk

This is the case where code is in the production but failing the tests which really did pass on the test env

This was the PR that was approved
https://github.com/topcoder-platform/community-app/pull/3057/files

And same code is in the production
https://github.com/topcoder-platform/community-app/blob/master/src/shared/components/challenge-detail/Specification/SideBar/ShareSocial.jsx

also here is the screenshot

Sample Challenge for Test for Accessibility Challenge 2019-07-30 13-07-22

@lakshmiathreya
Copy link

This is working on Chrome/Prod url - could you double check @tosha5252

@lakshmiathreya
Copy link

fyi @nkumar-topcoder @sushilshinde

@drasticdpk
Copy link
Collaborator

@lakshmiathreya still I am having issue. Please confirm.
https://monosnap.com/file/PQpBGL8XJrECAs9WvwgXgT9P9zyT45

@lakshmiathreya
Copy link

@drasticdpk - you are right - Chrome on Mac reads out Facebook correctly on Voice Over. Chrome on Window 10 Jaws reads it out as F.

@r0hit-gupta
Copy link
Collaborator

@lakshmiathreya @drasticdpk @sushilshinde it might be due to the fact that the facebook is not exactly an icon image but a div.

@r0hit-gupta r0hit-gupta mentioned this issue Jul 30, 2019
@r0hit-gupta
Copy link
Collaborator

New PR at #3164

Should solve this issue for once and all. Please review.

@lakshmiathreya
Copy link

Verified hover on Facebook icon reading out 'Facebook'... Win10/Chrome/NVDA & MacOS/Chrome/VoiceOver ... Closing Issue ...

@crazyk07
Copy link

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30097099

This is an automated message for crazyk via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests