Skip to content

Notification: Link in broadcast messages #4122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SathyaJayabal opened this issue Mar 18, 2020 · 11 comments
Closed

Notification: Link in broadcast messages #4122

SathyaJayabal opened this issue Mar 18, 2020 · 11 comments

Comments

@SathyaJayabal
Copy link
Collaborator

Expected: Clicking the broadcast message must take the. user to the respective page

Actual: The link is displayed as part of the broadcast message

cc @sachin-maheshwari
Screenshot 2020-03-18 at 3 24 14 PM

@luizrrodrigues
Copy link
Collaborator

@Oanh-and-only-Oanh Please confirm this.

We going to use the link directly in the Notification body with the highlighted test (in e.g. above the Topcoder will be blue like "View all Notifications". Or we'll make the whole notification item as a link, as we have in Challenge Notifications type?

@Oanh-and-only-Oanh
Copy link

@luizrrodrigues, the notification item should take them to the respective page.

@luizrrodrigues
Copy link
Collaborator

@Oanh-and-only-Oanh Yep, this requirement is okay.

Question is about if not will show link in notification body level, like the example above (screenshot) only Topcoder will be a link.

@luizrrodrigues
Copy link
Collaborator

If follow example above, notifications with a link will show like this:
image

@Oanh-and-only-Oanh
Copy link

@luizrrodrigues, see below
Screen Shot 2020-03-18 at 1 20 40 PM

@luizrrodrigues
Copy link
Collaborator

Okay, I just update Sachin:3 public group testing Topcoder to confirm :)

I think not a better way, think about we add a new field to API response with the URL and make whole notification item as a link, like challenge items.

But this change will need to do in the backend, so we can do this later.

I'll make the updates like the request above.

luizrrodrigues added a commit to topcoder-platform/navigation-component that referenced this issue Mar 21, 2020
@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal I'm done the implementation and build is running (ready to QA in 20min).

But need to fix links in notifications items.

Screen Shot 2020-03-21 at 16 03 30

Need to change herf to href

@luizrrodrigues
Copy link
Collaborator

The build is done:
image

@SathyaJayabal SathyaJayabal added QA Fail QA verification on Dev has failed. Assignee to redo the fix. Test Env Environment QA Pass and removed Ready for QA QA Fail QA verification on Dev has failed. Assignee to redo the fix. labels Mar 23, 2020
@SathyaJayabal
Copy link
Collaborator Author

verified on test env
Screenshot 2020-03-23 at 10 39 26 AM
Screenshot 2020-03-23 at 10 39 30 AM

@SathyaJayabal
Copy link
Collaborator Author

Verified by @sushilshinde beta(feature branch)

@SathyaJayabal SathyaJayabal added Beta Env Environment and removed Test Env Environment labels Mar 26, 2020
@SathyaJayabal SathyaJayabal added this to the v0.27.0 milestone Mar 30, 2020
@SathyaJayabal
Copy link
Collaborator Author

can be verified on production only when a broadcast message with a link is published.

@SathyaJayabal SathyaJayabal added Prod Env Environment and removed Beta Env Environment labels Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants