Skip to content

Notification pop-up inconsistent #4140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sushilshinde opened this issue Mar 26, 2020 · 11 comments
Closed

Notification pop-up inconsistent #4140

sushilshinde opened this issue Mar 26, 2020 · 11 comments
Assignees
Labels
Notifications P2 Important (resolve within 3 days) Prod Env Environment QA Pass
Milestone

Comments

@sushilshinde
Copy link
Collaborator

@luizrrodrigues sometimes I see this pop-up

Topcoder Challenges 2020-03-26 17-00-20

and sometimes I see this

Topcoder Challenges 2020-03-26 17-11-40

FYI @Oanh-and-only-Oanh @SathyaJayabal

@sushilshinde sushilshinde added P2 Important (resolve within 3 days) Notifications labels Mar 26, 2020
@SathyaJayabal SathyaJayabal added the Beta Env Environment label Mar 26, 2020
@Oanh-and-only-Oanh
Copy link

@Dara-K, from a UI perspective, when should members see the above?

@Dara-K
Copy link

Dara-K commented Mar 26, 2020

When they have read all notifications. That's also why the "Mark all as read" link is not there anymore.

@SathyaJayabal
Copy link
Collaborator

@Oanh-and-only-Oanh , the. issue is members should see the empty state only when they do not have any notifications. But sometimes for the same user, they see both the above randomly. Sometimes it shows the empty state and sometimes with notifications.

@SathyaJayabal
Copy link
Collaborator

cc @sushilshinde

@luizrrodrigues
Copy link
Collaborator

@Oanh-and-only-Oanh @Dara-K @SathyaJayabal

Yeah, the issue here is about sometimes the notifications items not loaded.

This happen after login if refresh back to normal. I'll check this one.

@luizrrodrigues
Copy link
Collaborator

@sushilshinde I can't reproduce this one anymore, maybe was API instability?
Can you recheck and let me know if still able to see the issue?

cc @SathyaJayabal

Thanks

@luizrrodrigues
Copy link
Collaborator

UPDATE
I have found the issue, this happen when user token is changed. It is updated regularly over a period of time.

Working on fix.

@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal @sushilshinde
This was fixed and ready for QA in Beta.

@SathyaJayabal
Copy link
Collaborator

@luizrrodrigues , verified on beta. The notifications load correctly every time.

@SathyaJayabal
Copy link
Collaborator

Verified on beta (develop branch)

@SathyaJayabal
Copy link
Collaborator

verified on prod.

@SathyaJayabal SathyaJayabal added Prod Env Environment and removed Beta Env Environment labels Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Notifications P2 Important (resolve within 3 days) Prod Env Environment QA Pass
Projects
None yet
Development

No branches or pull requests

5 participants